fix: recover macos functionality #2408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewann
requested review from
pdenert,
piotruela and
mateuszwojtczak
as code owners
|
To view this pull requests documentation preview, visit the following URL: docs.page/leancodepl/patrol~2408 Documentation is deployed and generated using docs.page. |
github-actions
bot
added
the
package: patrol
mateuszwojtczak
approved these changes
Nov 13, 2024
|
Also, please update the changelog like here: 902b07f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋
This PR recovers macOS testing functionality, which I last saw working in 3.10.0. Since then it appears to fail with:
this still seems an issue at commit: 6a1df02
Testing:
works on my machine. I didn't quickly find a test suite to run / update locally, though at a guess there is some coverage missing for this functionality / platform. Let me know if there are other things I can do to help with this submission.